New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trac #3428 #85
Trac #3428 #85
Conversation
do_transformation_test("POINT (30 10)", "MULTIPOINT ((30 10))", transfn); | ||
do_transformation_test("LINESTRING Z (30 10 4,10 30 5,40 40 6)", "MULTIPOINT Z (30 10 4,10 30 5,40 40 6)", transfn); | ||
do_transformation_test("POLYGON((35 10,45 45,15 40,10 20,35 10),(20 30,35 35,30 20,20 30))", "MULTIPOINT(35 10,45 45,15 40,10 20,35 10,20 30,35 35,30 20,20 30)", transfn); | ||
do_transformation_test("MULTIPOINT M (10 40 1,40 30 2,20 20 3,30 10 4)", "MULTIPOINT M (10 40 1,40 30 2,20 20 3,30 10 4)", transfn); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth adding some curves here too, and TIN...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function being tested is a pretty thin wrapper around the LWPOINTITERATOR
, which has its own tests for all of these types. I can add a couple additional cases here, though.
I think a larger issue is that it's currently a bit of a pain to add tests for all of the different types, especially when you think of all the different ways to get an EMPTY. I think it would be worthwhile either to have some kind of random geometry generator (which you can start with a specified seed) or some standard lists of test geometries that can be pulled in to any individual test as desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committed at r14604 |
https://trac.osgeo.org/postgis/ticket/3428