#3362 - Add function for DBSCAN clustering algorithm #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3765,6 +3777,13 @@ CREATE AGGREGATE ST_ClusterWithin (geometry, float8) ( | |||
| FINALFUNC = pgis_geometry_clusterwithin_finalfn | |||
| ); | |||
|
|
|||
| -- Availability: 2.3 | |||
| CREATE AGGREGATE ST_DBSCAN (geometry, float8, int) ( | |||
There was a problem hiding this comment.
You've established a pattern of ST_Cluster* as the naming convention, would be good to keep?
|
Merged at r14674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the liblwgeom internals of ST_ClusterWithin and ST_ClusterIntersecting to make them a bit simpler and more similar, then replaces ST_ClusterWithin with DBSCAN, of which ST_ClusterWithin is a special case.
I haven't done much testing on this yet, although it passes the existing test suite and produces results equivalent to the R 'dbscan' package in the cases I've tried.
This also extends (again) the aggregation machinery in
lwgeom_accum.c, since we now need to pass two constant arguments to the finalizer function instead of just one. If we decide to go the windowing route for 2.3, this stuff should be backed out.