-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds .toggleActive method #61
Conversation
method: 'GET', | ||
url: '/getById?id=8' | ||
}, function (res) { | ||
t.ok(res.result, 'the toggle active function has enabled the previously inactive chal'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this test will always pass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - my bad!!
method: 'GET', | ||
url: '/getById?id=2' | ||
}, function (res) { | ||
t.deepEqual(res.result, active, 'empty array returned because chal is deactivated'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think there is a wrong comment on this line.
Current coverage is 93.85% (diff: 93.75%)@@ master #61 diff @@
==========================================
Files 16 17 +1
Lines 212 228 +16
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 199 214 +15
- Misses 13 14 +1
Partials 0 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @mk4111 and @JMurphyWeb for the review 👍
adds .toggleActive method and adds tests.
Tests fail because this PR relies on #60 to be merged in first
Can remove Boom if that's preferred