adds .toggleActive method #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-meister
reviewed
Dec 12, 2016
| method: 'GET', | ||
| url: '/getById?id=8' | ||
| }, function (res) { | ||
| t.ok(res.result, 'the toggle active function has enabled the previously inactive chal'); |
There was a problem hiding this comment.
I feel like this test will always pass?
jay-meister
reviewed
Dec 12, 2016
| method: 'GET', | ||
| url: '/getById?id=2' | ||
| }, function (res) { | ||
| t.deepEqual(res.result, active, 'empty array returned because chal is deactivated'); |
There was a problem hiding this comment.
Think there is a wrong comment on this line.
Current coverage is 93.85% (diff: 93.75%)@@ master #61 diff @@
==========================================
Files 16 17 +1
Lines 212 228 +16
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 199 214 +15
- Misses 13 14 +1
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds .toggleActive method and adds tests.
Tests fail because this PR relies on #60 to be merged in first
Can remove Boom if that's preferred