Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #563
Without this change, having multiple users results in Prometheus processing errors downstream along the lines of:
Prometheus Reference
https://prometheus.io/docs/instrumenting/exposition_formats/#grouping-and-sorting
Example setup
In the example below, I tested with an extra user defined in
examples/docker/pgcat.toml
, e.g.Example Output: Before
Using
pgcat_stats_total_xact_count
as an example, to cull down the overall amount of text I'm pasting here.$ cat metrics_before_fix.txt | grep pgcat_stats_total_xact_count
Example Output: After
$ cat metrics_after_fix.txt | grep pgcat_stats_total_xact_count