Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Make sure the GCE ingress uses the defined readiness probe definition #203

Open
guidoiaquinti opened this issue Nov 25, 2021 · 4 comments
Labels
bug Something isn't working gcp Google Cloud Platform helm Helm chart work P1 Urgent, non-breaking

Comments

@guidoiaquinti
Copy link
Contributor

Bug description

While working on the e2e test for GCP, I found the GCE Ingress (GLB) not picking up the health check information from the readiness probe definition. Instead, it is using the default / making the health check to fail (as the app returns an HTTP 302).

This StackOverflow thread might have more info.

Expected behavior

When we deploy PostHog to GCP, the ingress load balancer uses the HTTP /_health path as readiness probe.

Actual behavior

When we deploy PostHog to GCP, the ingress load balancer uses the HTTP / path as readiness probe.

How to reproduce

  1. Install PostHog on GCP
@guidoiaquinti guidoiaquinti added bug Something isn't working gcp Google Cloud Platform labels Nov 25, 2021
@guidoiaquinti
Copy link
Contributor Author

Note for myself: once the issue is fixed, we should re-enable the ingestion test we disabled:

#
# TODO: the GCE Ingress is not picking up health check from readiness probe definition and it's using '/'
# instead. We need to fix this issue before being able to enable the k6 ingestion test.
#
# see: https://stackoverflow.com/questions/44584270/
#
# - name: Run ingestion test using k6
# uses: k6io/action@v0.2.0
# with:
# filename: ci/k6-ingestion-test.js

@tiina303 tiina303 added the P1 Urgent, non-breaking label Nov 25, 2021
@fuziontech fuziontech added the helm Helm chart work label Jan 18, 2022
@georgekaz
Copy link

Is there any workaround for this other than manually adding /_health to the health check in the GCP console? Will you add backend config https://cloud.google.com/kubernetes-engine/docs/concepts/ingress#direct_hc and add the cloud.google.com/backend-config annotation as per https://cloud.google.com/kubernetes-engine/docs/how-to/ingress-features#create_service ?

Thanks

@guidoiaquinti
Copy link
Contributor Author

👋 Hey @georgekaz , unfortunately I wasn't able to push a workaround/fix for this in #209. The task is currently in our backlog and hasn't been prioritised.

Let us know if you find a way to make it working and I'll be happy to push the change. I'm unfortunately pretty new to GKE.

Thank you!

@georgekaz
Copy link

georgekaz commented Feb 24, 2022

I couldn't find a way to make this work without too much bother so I decided to use nginx ingress instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gcp Google Cloud Platform helm Helm chart work P1 Urgent, non-breaking
Projects
None yet
Development

No branches or pull requests

4 participants