Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pass options to default parser #13

Merged
merged 1 commit into from
Jul 18, 2016
Merged

Allow pass options to default parser #13

merged 1 commit into from
Jul 18, 2016

Conversation

kisenka
Copy link
Contributor

@kisenka kisenka commented Jul 13, 2016

This allows to override posthtml-parser default options (which is actually htmlparser2 parser options) and decrease pain when working with SVG.

@coveralls
Copy link

coveralls commented Jul 13, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 211895d on kisenka:parser-options into be3cf2a on posthtml:master.

@kisenka kisenka mentioned this pull request Jul 13, 2016
Closed
@kisenka
Copy link
Contributor Author

kisenka commented Jul 13, 2016

Related PR to posthtml-parser - posthtml/posthtml#150

@voischev
Copy link
Member

voischev commented Jul 13, 2016 •
edited
Loading

posthtml/posthtml#150 (comment)

fixed this PR plz

@kisenka
Copy link
Contributor Author

kisenka commented Jul 14, 2016

@voischev that you mean "fixed"?

@voischev
Copy link
Member

voischev commented Jul 14, 2016 •
edited
Loading

module should work like posthtml/posthtml#150 (comment)

@kisenka
Copy link
Contributor Author

kisenka commented Jul 15, 2016

@voischev add wrapper & tests, please check.

@coveralls
Copy link

coveralls commented Jul 15, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling d505e63 on kisenka:parser-options into be3cf2a on posthtml:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9f46f2c on kisenka:parser-options into e90adc2 on posthtml:master.

voischev
voischev reviewed Jul 15, 2016
View reviewed changes
index.js
}

function isObject(o) {
return typeof o === 'object' && !Array.isArray(o);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return o != null && typeof o === 'object' && !Array.isArray(o);
https://github.com/jonschlinkert/isobject/blob/master/index.js#L13

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@voischev add isobject as dependency

@coveralls
Copy link

coveralls commented Jul 15, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 2ff88f3 on kisenka:parser-options into e90adc2 on posthtml:master.

@voischev
Copy link
Member

LGTM

@kisenka
Copy link
Contributor Author

kisenka commented Jul 16, 2016 •
edited
Loading

@voischev good. Now we are waiting approval from other maintainers?

@voischev
Copy link
Member

@kisenka yes.
@posthtml/collaborators ping

@qfox
Copy link
Contributor

qfox commented Jul 17, 2016

Heya, can you please rebase? or squash and rebase?

@kisenka
Allow pass options to parser
2cdc3e6 
Add wrapper over posthtml-parser as requested in posthtml/posthtml/pull/150#issuecomment-232707133;
Add tests to cover possible wrapper issues;

Add isobject dependency
@kisenka
Copy link
Contributor Author

kisenka commented Jul 18, 2016

@zxqfox done, please check

@coveralls
Copy link

coveralls commented Jul 18, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 2cdc3e6 on kisenka:parser-options into e90adc2 on posthtml:master.

@qfox
Copy link
Contributor

qfox commented Jul 18, 2016

LGTM

@kisenka
Copy link
Contributor Author

kisenka commented Jul 18, 2016

All checks done, can anybody merge it?

@qfox
Copy link
Contributor

qfox commented Jul 18, 2016

Oh, right. Sorry 🐱

@voischev Do you mind to publish minor?

@qfox qfox merged commit d368591 into posthtml:master Jul 18, 2016
@kisenka
Copy link
Contributor Author

kisenka commented Jul 18, 2016

Thanks! 👍

@kisenka kisenka deleted the parser-options branch July 18, 2016 18:54
@kisenka
Copy link
Contributor Author

kisenka commented Jul 19, 2016

Guys, what about minor release? :)

@awinogradov
Copy link
Member

@voischev ping

@voischev
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kisenka @coveralls @voischev @qfox @awinogradov