This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
OBS-419: Fix distinct ID for Postman API key users. #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were calling /v1/users to get an email to use as a distinct ID only when an Akita API Key was present.
mgritter
added
the
3 – Normal Priority
shreys7
reviewed
Oct 4, 2023
| // To use a Postman API key we'd have to both obfuscate it (logging | ||
| // the user's API key would be bad) and have a way to map it to a | ||
| // particular user -- seems better to fall back to local IDs. | ||
| func DistinctIDFromCredentials() string { |
There was a problem hiding this comment.
The comment and the implementation seems contradicting 🤔
We are saying we should not use Postman API Key for distinct id, but we are returning it from this function.
There was a problem hiding this comment.
Also, shouldn't this function try getting an ID from the Akita API Key too if it did not find one from the Postman API Key?
There was a problem hiding this comment.
You're correct, this was the wrong function.
shreys7
approved these changes
Oct 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were calling /v1/users to get an email to use as a distinct ID only when an Akita API Key was present.