Added support for usage of XML examples of type string. #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/unit/convertV2.test.js
Outdated
| @@ -1107,6 +1108,25 @@ describe('The convert v2 Function', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| it('Should convert xml request body with complete string example correctly', function(done) { | |||
| const openapi = fs.readFileSync(xmlrequestExampleBody, 'utf8'); | |||
| Converter.convert({ type: 'string', data: openapi }, | |||
There was a problem hiding this comment.
If this is a convertV2 test, shouldn't we use the convertV2 method? And in that case requestParametersResolution will not be applicable right?
There was a problem hiding this comment.
Yes, missed this. Have updated test to use correct option and interface.
…o use v2 interface
…o use v2 interface
dhwaneetbhatt
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for usage of string type of XML examples even for complex types like object and array. Existing support for constructing example based on
xmlfield will still continue to support but mentioning example at any schema level of type string will override the mentioned example to be used in generated collection.