Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sending OAuth2 callback url x-www-form-encoded #861

Closed
eli-b opened this issue Jan 1, 2015 · 6 comments
Closed

Enable sending OAuth2 callback url x-www-form-encoded #861

eli-b opened this issue Jan 1, 2015 · 6 comments

Comments

@eli-b
Copy link

eli-b commented Jan 1, 2015

Python's oauthlib requires that callback urls be x-www-form-urlencoded. Please enable sending the callback url in this way.

@a85 a85 added the feature label Feb 5, 2015
@eli-b
Copy link
Author

eli-b commented Feb 10, 2015

The following issue seems related: #752

@a85 a85 added transfer and removed transfer labels Jan 27, 2016
@aeneasr
Copy link

aeneasr commented Jul 24, 2016

The OAuth2 Specification is pretty clear on this issue: https://tools.ietf.org/html/rfc6749#section-4.1.3

4.1.3. Access Token Request
The client makes a request to the token endpoint by sending the
following parameters using the "application/x-www-form-urlencoded"
format per Appendix B with a character encoding of UTF-8 in the HTTP
request entity-body:

This isn't a feature, it's a bug

@abhijitkane
Copy link
Member

@arekkas @eli-b
screen shot 2016-07-25 at 14 01 13

With the "Request access token locally" option selected, this is the POST /access_token request that's made from the app. The redirect_uri parameter is included in the form data, and the request content type is application/x-www-form-urlencoded.

@aeneasr
Copy link

aeneasr commented Jul 25, 2016

Right, sorry, my bad. In fact, everything was (almost) working fine - except that postman seems to be url encoding special chars in client secrets. For example, the password lidFNXvQOf5eH!$h yields this base64 string YTVkZTRiOWUtOTEyNS00ZmZiLTg2NTMtN2Y3ZTkzMjRjMzM1OmxpZEZOWHZRT2Y1ZUghJTI0aA== which gives, when decoded a5de4b9e-9125-4ffb-8653-7f7e9324c335:lidFNXvQOf5eH!%24h

@a85 a85 added the Auth label Feb 4, 2017
@czardoz
Copy link

czardoz commented Mar 21, 2017

@arekkas The RFC says that

The client identifier is encoded using the
   "application/x-www-form-urlencoded" encoding algorithm per
   Appendix B, and the encoded value is used as the username; the client
   password is encoded using the same algorithm and used as the
   password.

https://tools.ietf.org/html/rfc6749#section-2.3.1

@czardoz czardoz moved this from Suggestions to Doing in OAuth 2 Mar 21, 2017
@aeneasr
Copy link

aeneasr commented Mar 21, 2017

Again I have to apologize, looks like everything is working as specified :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

6 participants