Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth2: basic auth should www-url-decode client id and secret #150

Closed
aeneasr opened this issue Mar 21, 2017 · 0 comments · Fixed by #151
Closed

oauth2: basic auth should www-url-decode client id and secret #150

aeneasr opened this issue Mar 21, 2017 · 0 comments · Fixed by #151
Labels
bug Something is not working.

Comments

@aeneasr
Copy link
Member

aeneasr commented Mar 21, 2017

see postmanlabs/postman-app-support#861 (comment)
@aeneasr aeneasr added the bug Something is not working. label Mar 21, 2017
@aeneasr aeneasr mentioned this issue Mar 22, 2017
Closed
aeneasr pushed a commit that referenced this issue Mar 23, 2017
oauth2: basic auth should www-url-decode client id and secret - closes …
605a5ae 
…#150
@aeneasr aeneasr mentioned this issue Mar 23, 2017
Merged
aeneasr pushed a commit that referenced this issue Apr 14, 2017
@arekkas
oauth2: basic auth should www-url-decode client id and secret - closes …
ad395bf 
…#150
aeneasr pushed a commit that referenced this issue May 3, 2017
oauth2: revert basic auth change from issue #150
05876bf 
Reverting this change because BasicAuth already decodes the payloads
properly. This change actually introduced some bugs.
aeneasr pushed a commit that referenced this issue May 3, 2017
access: revert regression issue introduced by #150
67237cb
aeneasr pushed a commit that referenced this issue May 3, 2017
access: revert regression issue introduced by #150
ba6fde2
aeneasr pushed a commit that referenced this issue May 3, 2017
@arekkas
access: revert regression issue introduced by #150
6bb4135
aeneasr pushed a commit that referenced this issue May 3, 2017
@arekkas
access: revert regression issue introduced by #150
6f13d58
budougumi0617 added a commit to budougumi0617/fosite that referenced this issue May 10, 2019
@budougumi0617
oauth2: basic auth should www-url-decode client id and secret - closes …
9791a7e 
…ory#150
budougumi0617 added a commit to budougumi0617/fosite that referenced this issue May 10, 2019
@budougumi0617
access: revert regression issue introduced by ory#150
d4a1685
budougumi0617 added a commit to budougumi0617/fosite that referenced this issue May 10, 2019
@budougumi0617
access: revert regression issue introduced by ory#150
fba6111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

oauth2: basic auth should www-url-decode client id and secret ory/fosite
1 participant
@aeneasr