Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add objective-c codegen #126

Merged
merged 15 commits into from
Nov 22, 2019
Merged

Add objective-c codegen #126

merged 15 commits into from
Nov 22, 2019

Conversation

umeshp7
Copy link
Member

@umeshp7 umeshp7 commented Nov 18, 2019

Copy link
Member

@shreys7 shreys7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WE also need to add this in language labels.json right?

codegens/objective-c/lib/index.js Outdated Show resolved Hide resolved
codegens/objective-c/lib/index.js Outdated Show resolved Hide resolved
codegens/objective-c/lib/index.js Outdated Show resolved Hide resolved
codegens/objective-c/lib/index.js Outdated Show resolved Hide resolved
codegens/objective-c/lib/index.js Outdated Show resolved Hide resolved
codegens/objective-c/lib/index.js Outdated Show resolved Hide resolved
codegens/objective-c/lib/index.js Outdated Show resolved Hide resolved

// TODO: use defaultSessionConfiguration
// codeSnippet += 'NSURLSessionConfiguration *config = [NSURLSessionConfiguration defaultSessionConfiguration];\n';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add multiple/no/single file handling code here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meaning?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TODO is different from that.
I have added the file handling elsewhere.

Copy link
Member

@shreys7 shreys7 Nov 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually what I meant was add the file handling code we added before parsrBody function call.

codegens/objective-c/lib/index.js Outdated Show resolved Hide resolved
@@ -29,6 +29,7 @@ List of supported code generators:
| NodeJs | Native |
| NodeJs | Request |
| NodeJs | Unirest |
| Objective-C| NSURLSession|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space b/w -C and |?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the preview it doesn't make a difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants