Fixed URL path extraction with media type extension #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codenirvana
force-pushed
the
bugfix/GH-1267/url-path-variable-not-parsing-with-media-extensions
branch
from
3d1b7c3
to
c10e4be
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1268 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 2162 2167 +5
Branches 660 658 -2
=========================================
+ Hits 2162 2167 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
coditva
approved these changes
May 24, 2022
| @@ -13,6 +13,7 @@ var _ = require('../util').lodash, | |||
| HTTPS_PORT = '443', | |||
| HTTP_PORT = '80', | |||
| PATH_SEPARATOR = '/', | |||
| PATH_VARIABLE_SEPARATOR = '.', | |||
There was a problem hiding this comment.
non-blocker: Not sure about the variable name here. . isn't separating the path variables. It's just a character that shouldn't be part of the path key.
codenirvana
approved these changes
May 24, 2022
codenirvana
deleted the
bugfix/GH-1267/url-path-variable-not-parsing-with-media-extensions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: