Added cookie interaction integration tests for pm.sendRequest #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunagpal
force-pushed
the
feature/pm-send-request-cookie-tests
branch
from
22d50aa
to
ae636d0
Compare
kunagpal
force-pushed
the
feature/pm-send-request-cookie-tests
branch
from
ae636d0
to
d9223d4
Compare
kamalaknn
requested changes
Aug 24, 2017
| pm.expect(_response).to.have.property('code', 200); | ||
| pm.expect(_response).to.have.property('status', 'OK'); | ||
| pm.expect(_response.json).to.equal({ cookies: {} }); | ||
| pm.expect(pm.cookies.has('foo')).to.be(false); |
There was a problem hiding this comment.
@kunagpal shouldn't we make sure these assertions pass, on testRun.test.getCall(0) or testRun.assertion.getCall(3). In order to make sure our tests fail for failures in sandbox scripts?
There was a problem hiding this comment.
Good idea, I'll add them.
kunagpal
added a commit
that referenced
this pull request
Aug 24, 2017
* Added explicit response body checks * Made test names consistent and useful * Rectified overall flakiness
kunagpal
force-pushed
the
feature/pm-send-request-cookie-tests
branch
from
a0172e1
to
b7034c0
Compare
kunagpal
added a commit
that referenced
this pull request
Aug 24, 2017
* Added explicit response body checks * Made test names consistent and useful * Rectified overall flakiness
* Added explicit response body checks * Made test names consistent and useful * Rectified overall flakiness
kunagpal
force-pushed
the
feature/pm-send-request-cookie-tests
branch
from
b7034c0
to
9466edc
Compare
kunagpal
added a commit
that referenced
this pull request
Aug 28, 2017
* release/6.3.1: fix(package): update postman-sandbox to version 2.3.3 fix(package): update postman-collection to version 2.1.3 6.3.1-beta.2 Bumped collection SDK to v2.3.1-beta.1 6.3.1-beta.1 Make sure `request.url.toString` is present before using it Addressed PR #359 comments * Added explicit response body checks * Made test names consistent and useful * Rectified overall flakiness Make sure empty Urls do not break runs Added cookie tests for pm.sendRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.