Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate legacy sandbox APIs #987

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Deprecate legacy sandbox APIs #987

merged 3 commits into from
Apr 1, 2024

Conversation

coditva
Copy link
Member

@coditva coditva commented Mar 15, 2024

Mark all legacy APIs as deprecated in typescript definition files.

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.65%. Comparing base (53b4ac3) to head (0cba765).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #987   +/-   ##
========================================
  Coverage    59.65%   59.65%           
========================================
  Files           12       12           
  Lines          575      575           
  Branches       140      140           
========================================
  Hits           343      343           
  Misses         232      232           
Flag Coverage Δ
unit 59.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coditva coditva marked this pull request as ready for review March 26, 2024 05:52
declare var tests;

/**
* @deprecated Use pm.global instead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @deprecated Use pm.global instead
* @deprecated Use pm.globals instead

declare var btoa;

/**
* @deprecated Use require('tv4') instead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @deprecated Use require('tv4') instead
* @deprecated Use require('ajv') instead

@codenirvana codenirvana merged commit 6fec074 into develop Apr 1, 2024
9 checks passed
@codenirvana codenirvana deleted the deprecate/legacy-api branch April 1, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants