Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links within iframe are replacing the frame #28

Closed
Vernal opened this issue Jul 25, 2015 · 1 comment
Closed

Links within iframe are replacing the frame #28

Vernal opened this issue Jul 25, 2015 · 1 comment
Assignees
@DavidCramer
Milestone
1.0

Comments

@Vernal
Copy link
Contributor

Vernal commented Jul 25, 2015

We need to set a global target for any links which are displayed within the iframe. They should all target="_blank"
@Vernal Vernal modified the milestone: 1.0 Jul 27, 2015
DavidCramer referenced this issue Jul 27, 2015
@DavidCramer
bind links to parent
797a3e5
@Vernal
Copy link
Contributor Author

Vernal commented Jul 29, 2015

hey this is a bad idea for the link to jump to the comment form. need to undo for that one:
https://www.evernote.com/l/AAQR7QOZ3U5Bh4u11tEuu4v1dfJAHKpze90

@Vernal Vernal reopened this Jul 29, 2015
DavidCramer added a commit that referenced this issue Jul 29, 2015
@DavidCramer
addresses #28 in part
f3b3a2c
@Vernal Vernal closed this as completed Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavidCramer DavidCramer

Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@Vernal @DavidCramer