Make it possible to disable server startup in the at_exit block #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,15 @@ module Application | |||
|
|
|||
| module_function | |||
|
|
|||
| # Control wheter or not the application will be run using an at_exit block. | |||
There was a problem hiding this comment.
Spelling mistake in "whether", but otherwise, lgtm. 👍
|
Not sure if we want this. If you're including the Application then you want it to auto-run. I think the correct solution would be to not require goliath/goliath in your spec. If it's specific things you need, require those bits directly. Not pulling goliath::Application into your spec would solve the issue I think. |
|
If you guys have any suggestions about how to fix this in another way: I'm open for alternatives. |
|
Seems to make sense to me. @dj2? :) |
|
I would find this useful too for testing. |
igrigorik
added a commit
that referenced
this pull request
Nov 18, 2012
Make it possible to disable server startup in the at_exit block
|
Merged - thanks! @dj2 if you have a better way.. we can revert. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hook is executed after any program that load Goliath::Application.
It made my sprockets-for-goliath gem specs to fail (see failed travis build).