Fix bottleneck when using confirms #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 29, 2013 10:53
Publishing msgs using confirms can create a situation where so many event listeners are registered that `exchange.removeListener` becomes a significant bottleneck (see https://gist.github.com/aheckmann/7762370) Instead of relying on EventEmitter we now register a single error handler for the exchange and handle error disbursement manually. Results of running the above gist as follows: > time DEBUG=amqp:* COUNT=30000 PREFETCH=0 BUCKET_SIZE=20000 node index.js before applying the fix: real 1m22.216s user 1m10.973s sys 0m16.106s after: real 0m25.034s user 0m14.082s sys 0m15.153s
it doesnt belong on a Promise. we just use "once" instead
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishing msgs using confirms can create a situation where so many event listeners are registered that
exchange.removeListenerbecomes a significant bottleneck (see https://gist.github.com/aheckmann/7762370)Instead of relying on
EventEmitter, this PR now registers a single error handler for the exchange and handle error disbursement manually.Results of running the above gist as follows:
> time DEBUG=amqp:* COUNT=30000 PREFETCH=0 BUCKET_SIZE=20000 node index.jsbefore applying the fix:
after:
Also tried to make whitespace use more consistent throughout the project base on what seemed to be the predominant style.