negotiate channelMax with the server #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
3.3.5 is out and without this patch node-amqp cannot connect to rabbitmq server who has set the channel_max property. |
|
This change is very important. Services such as CloudAMQP from Heroku already migrated to the new version and won't let you connect. |
postwait
added a commit
that referenced
this pull request
Jan 28, 2015
negotiate channelMax with the server
|
Will a new version be released too soon? |
|
I'll try to get to it next week. I'm traveling this week. |
|
Ok, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very important for upcoming RabbitMQ 3.3.5, that will close connections that don't respect the channelMax set by the server.