transparency corruption, 24-bit speed and quality #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resulted in nasty corruption in partially transparent images: upper parts had flipped pixel pairs, lower parts had spurious white pixels.
As a side effect, this also drastically improves speed -- there's no reason to convert colors anymore, and on non-lineart images almost all hash lookups are misses.
That is, those whose upper or left half is unset.
|
Turns out a messed up during a refactor a year ago: b8b0c0b |
|
Sorry I didn't merge this. I had to go back in time to fix some other issues but I added your alpha suggestion 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a bunch of fixes for high-resolution mode: