Allow images to be piped in via stdin #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes posva#9 If the image-file argument is "-", the program tries to read input from stdin instead of a file.
|
That's pretty cool. Thanks for the PR. I'll test it on OS X |
|
Yes, I tested all the test images. The behavior is same for manually passing the filename, piping through cat and using input redirection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9
If the image-file argument is "-", the program tries to read input from stdin
instead of a file.
The terminal cols function is modified to use stdout instead of stdin so that it produces correct output even if the program is being piped to.
NOTE: I have only tested this on Linux and not Windows. So, while I tried to lookup the differences and modify the program accordingly, it might not work properly.