-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to stb_image v2.19 #41
Conversation
Nice, thanks! Do you think you could add back ico support (#24), it seems to be removed right now. |
The patch just replaces the new stb_image.h and fixes some incompatible API usage with default arguments. Sorry for not validating more. I will try to resolve it later this weekend. |
ok, thanks! |
Hi @posva , I have made two additional commits in this pull request. Now it works on gif and ico. Could you look over them? I have no knowledge about any image file format. |
Hey, it still doesn't work with GIFs |
Hi, I am sorry for not testing the patch with multi-frame gifs. I reverted the previous patch on gif and made a new commit. The crash seems to be fixed by the new patch (3fa8440). Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@posva Hi! Do you mind tagging a new release now that this is fixed? thanks! |
Done, If someone could create the PRs to homebrew that would be perfect. Otherwise I will do in Xmas |
This fixes the following issue: #34 #38 #36 #37 #39.
#40 turns out to be a heap-use-after-free error. Please review the usage of the following two API from stb.
stbi__gif_load_next
stbi__load_main