Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Color Respecting Failure in Dark Mode #519

Open
nerdvana42 opened this issue Oct 15, 2021 · 0 comments
Open

Windows Color Respecting Failure in Dark Mode #519

nerdvana42 opened this issue Oct 15, 2021 · 0 comments

Comments

@nerdvana42
Copy link

Look at the colors!
Look at the colors part 2!

Attached are the two images I already shared with you.

<<<<<LOG OF CONVERSATION ON MUS*H>>>>>

From afar, Mike waves.

You paged Mike with 'Hey there! :)'

From afar, Mike is afraid he's just heading to bed, but - what version of Windows is your friend using? Potato should, in theory, pull its colours from the Windows theme, so if they're using dark mode the colours should change to match. But failing that I can try and give them something to tweak it.

You paged Mike with 'She's gone offline. I'll find out as soon as I can and update you. I can tell you that mine doesn't work that way. Mind a quick picture share?'

Mike pages: Not at all.

You paged Mike with 'putting it together, OMP'

From afar, Mike NPs

You paged Mike with 'https://i.imgur.com/lcgqJ6J.png'

You paged Mike with 'I've got Windows 10 (not totally updated but fairly recently) and I'm showing you my Potato version. :)'

Mike pages: What does typing this in your input window give you?

Mike pages: /eval winfo rgb . SystemButtonFace

Return (17): 61680 61680 61680

You paged Mike with 'Return (17): 61680 61680 61680'

From afar, Mike hums.

Mike pages: So Tk (the graphical library Potato uses) should respect your Windows settings for certain colours. But it doesn't seem to be accounting for dark mode.

Long distance to Mike: Nerdvana nods. "That matches what I feel like I'm experiencing myself."

You paged Mike with 'If you want you could hold off on this. Go to bed. I just wanted to reach out to you about this. :)'

Mike pages: Can I ask you to put up a ticket for me?

You paged Mike with 'Sure. Where?'

Mike pages: https://github.com/potatomushclient/potato

Mike pages: https://github.com/potatomushclient/potato/issues more specifically

Mike pages: As a quick temp workaround, however, can I ask you to open a new copy of Potato (just in case it's horrendous) and do this for me:

You paged Mike with 'Okay, I don't have a github account so the ticket is pending...'

Mike pages: /eval tk_setPalette #2b2a33 ; foreach ClassType {TFrame TLabel Toolbutton TButton} {::ttk::style configure $ClassType -background #2b2a33 -foreground white}

You paged Mike with 'some improvement: https://i.imgur.com/PuWphYN.png'

You paged Mike with 'but there's still the brightness at the top.'

You paged Mike with 'BTW, tickets don't seem to be touched much. My wife (AdelinFDM) submitted one a while back and it hasn't been touched.'

Mike pages: Unfortunately those bits are almost entirely out of my control: The title bar and the menu are both drawn and coloured by Tk. The menu can kinda potentially be worked around by not using the built in menu and creating a custom one instead, which would let me colour it, but I wouldn't be able to do anything about the title bar with the app name and minmise/max buttons, etc. Though I can try and raise a ticket for the Tk devs to look at it all.

Mike pages: Yeah, I've not been particularly active with any of my coding projects for a while, tbh, been dealing with RL.

You paged Mike with 'Gotcha. Yeah, that's the brighest part of the window. RL sucks, I get it.'

Mike pages: FWIW, for me on Win 7 the title bar is drawn with the 'glass' effect other windows have.

From afar, Mike searches for tickets by your wife, only finds the one; will try and look at that at some point in the moderately near future :)

You paged Mike with 'Its about playing sounds. TY for looking. She thought you'd stopped supporting Potato honestly.'

From afar, Mike hasn't really been actively developing, still supports, though mainly in terms of bug reporting/people having issues or things I get asked about in real time and can put quick snippets together for. I've not really had the time or enthusiasm for full-on development for a while, but hope to get back (or at least closer to) that at some point :)

You paged Mike with 'Gotcha. Well, she'd like to be able to go back to having sound-based triggers for people but right now all she can do is have it play youtube links.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant