add pojo support. closes #3

poteto · Feb 10, 2016 · a75de6b · a75de6b
1 parent fdea398
commit a75de6b
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 3 deletions.
diff --git a/addon/helpers/toggle.js b/addon/helpers/toggle.js
@@ -1,10 +1,10 @@
 import Ember from 'ember';
 
-const { Helper: { helper } } = Ember;
+const { Helper: { helper }, get, set } = Ember;
 
 export function toggle([obj, prop]) {
   return function() {
-    obj.toggleProperty(prop);
+    set(obj, prop, !get(obj, prop));
   };
 }
 

diff --git a/tests/unit/helpers/toggle-test.js b/tests/unit/helpers/toggle-test.js
@@ -14,5 +14,35 @@ test('it toggles the property', function(assert) {
   let action = toggle([jimBob, 'isAlive']);
   action();
 
-  assert.ok(get(jimBob, 'isAlive'), 'it toggles the property');
+  assert.ok(get(jimBob, 'isAlive') === true, 'it toggles the property');
 });
+
+test('it toggles the property of a POJO', function(assert) {
+  let jimBob = {
+    isAlive: false
+  };
+  let action = toggle([jimBob, 'isAlive']);
+  action();
+
+  assert.ok(get(jimBob, 'isAlive') === true, 'it toggles the property of a POJO');
+});
+
+test('it correctly toggles non-boolean falsy values', function(assert) {
+  let jimBob = {
+    isAlive: undefined
+  };
+  let action = toggle([jimBob, 'isAlive']);
+  action();
+
+  assert.ok(get(jimBob, 'isAlive') === true, 'it toggles the property of a POJO');
+});
+
+test('it correctly toggles non-boolean truthy values', function(assert) {
+  let jimBob = {
+    isAlive: {}
+  };
+  let action = toggle([jimBob, 'isAlive']);
+  action();
+
+  assert.ok(get(jimBob, 'isAlive') === false, 'it toggles the property of a POJO');
+});