Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CACI Rome #517

Merged
merged 1 commit into from Apr 5, 2017
Merged

Add CACI Rome #517

merged 1 commit into from Apr 5, 2017

Conversation

kethinov
Copy link
Contributor

@kethinov kethinov commented Apr 1, 2017

Add/Update/Remove

  • I have read the contributing guidelines
  • I agree to the Code of Conduct
  • I have followed the format prescribed in the contributing guidelines
  • (OPTIONAL) In your pull request message, add additional context on the interview process if necessary

@kethinov
Copy link
Contributor Author

kethinov commented Apr 1, 2017

FYI the links in the PR template are broken.

@poteto poteto merged commit 1a4c41c into poteto:master Apr 5, 2017
adiorion added a commit to adiorion/hiring-without-whiteboards that referenced this pull request Apr 5, 2017
The links in PRs such as poteto#517 don't go to the relevant docs. I don't know how to link from a PR to "a given file in in the current branch" so this updates them to point to the `master` branch.
@adiorion adiorion mentioned this pull request Apr 5, 2017
3 tasks
@adiorion
Copy link
Contributor

adiorion commented Apr 5, 2017

@kethinov I think #524 resolves the links problem, can you verify if it looks right on your end? Thanks!

@kethinov kethinov deleted the patch-1 branch April 5, 2017 21:03
poteto pushed a commit that referenced this pull request Apr 7, 2017
* fix links in PULL_REQUEST_TEMPLATE

The links in PRs such as #517 don't go to the relevant docs. I don't know how to link from a PR to "a given file in in the current branch" so this updates them to point to the `master` branch.

* PULL_REQUEST_TEMPLATE: use absolute github URLs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants