fix links in PULL_REQUEST_TEMPLATE #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The links in PRs such as poteto#517 don't go to the relevant docs. I don't know how to link from a PR to "a given file in in the current branch" so this updates them to point to the `master` branch.
|
I opened a trivial (pointless) PR to test this. Looks like it still doesn't work right. Using absolute URLs seems to work though. |
|
Oh duh looks like this isn't merged yet. No wonder it didn't work :O |
|
Yep, it does appear to work. Closed my test PR. |
|
Could you use an absolute link instead please? e.g. https://github.com/poteto/hiring-without-whiteboards/blob/master/CONTRIBUTING.md |
|
@poteto good idea! lemme push that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix internal doc links in PRs
The links in PRs such as #517 don't go to the relevant docs, they just say "Not Found". I don't know how to link from a PR to "a given file in in the current branch" so this PR updates them to point to the
masterbranch.Unfortunately this means that the links are broken in the file view https://github.com/poteto/hiring-without-whiteboards/blob/master/.github/PULL_REQUEST_TEMPLATE.md but I don't think it's possible to get both given current Github limitations?