Allow self referencing arrays

[ssured]

See pouchdb/pouchdb#2696

[calvinmetcalf]

I may be slow due to it being early but what is !/\d+/.test(name) doing? Also we should probably open an issue in ember about fucking around with globals

[ssured]

The regex tests for values being fully numeric.

/\d+/.test(‘1213’) === true
/\d+/.test(‘1aa3’) === false

Essentially what the code does is asserting all properties in an array must be array indices.

[ssured]

About Ember, I think this is not related to globals, it just sets custom properties on Arrays. which imo is valid:

a = [1,2]
a.self = a
console.log(JSON.stringify(a))

will output [1,2]

[calvinmetcalf]

ah then +1

[nolanlawson]

I'm going to move this to the pouchdb org. Also yeah, this PR makes sense.

[nolanlawson]

44a5164

[nolanlawson]

also I will say that I would have liked to have seen a test for this, but since we don't have any tests set up in this project, it's okay