allow_persistent_cookies not working

[Ciebiada]

Hi,

Is allow_persistent_cookies supported?

Steps to reproduce

❯ curl -X PUT http://root:root@localhost:5984/_config/couch_httpd_auth/allow_persistent_cookies -d '"true"'
true

❯ curl -v http://localhost:5984/_session -d 'name=michal1&password=michal1'     
*   Trying ::1...
* TCP_NODELAY set
* Connected to localhost (::1) port 5984 (#0)
> POST /_session HTTP/1.1
> Host: localhost:5984
> User-Agent: curl/7.54.0
> Accept: */*
> Content-Length: 29
> Content-Type: application/x-www-form-urlencoded
> 
* upload completely sent off: 29 out of 29 bytes
< HTTP/1.1 200 OK
< X-Powered-By: Express
< Access-Control-Allow-Origin: http://localhost:3000
< Vary: Origin, Accept-Encoding
< Access-Control-Allow-Credentials: true
< Set-Cookie: AuthSession=bWljaGFsMTo1QUQzMzIxMjrA_sQnHtpacJ8aEpTRTXkvohpD9A; Path=/; HttpOnly
< Content-Type: text/plain; charset=utf-8
< Content-Length: 40
< ETag: W/"28-0UwHQaxGthANXDHaMKfsV9Rw2Pg"
< Date: Sun, 15 Apr 2018 11:05:53 GMT
< Connection: keep-alive
< 
{"ok":true,"name":"michal1","roles":[]}
* Connection #0 to host localhost left intact

As you can see Set-Cookie doesn't include Expires= which means the cookie is a session one.

I'm using pouchdb-authentication and those cookies work very well with my React app. However I would like to make them persist

[marten-de-vries]

Seems like allow_persistent_cookie is't implemented. The cookie logic is here: https://github.com/pouchdb/pouchdb-server/blob/master/packages/node_modules/express-pouchdb/lib/routes/authentication.js

[Ciebiada]

I see.

Would you guys merge it If I created pull request for it?

[marten-de-vries]

@Ciebiada Yes, that would be great.