(#317) - Add allow_persistent_cookies config #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. Sorry for getting to this only now. This looks good! I'm happy to merge this, provided it passes the test suite. If you could rebase it against the latest master, that should fix the current Travis errors. I don't think there aren't any cookie-specific tests, if you want to add some that would be great, but I'm happy to take this as-is. |
Ciebiada
force-pushed
the
allow_persistent_cookies
branch
from
01dfa4e
to
f9c4b93
Compare
|
Thanks. Done! |
|
(Closed on accident) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
To have an easy way of persisting user's session
What:
Implement
allow_persistent_cookiessetting from CouchDB (https://github.com/apache/couchdb/blob/817b2b6f5f0883092df60c1ec8ec7ec6d6094a23/src/couch/src/couch_httpd_auth.erl#L443)I couldn't find any tests responsible for the actual cookies. Maybe you can point me into the right direction?