Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example for the REDIS_URL for the redisdown #311

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

seigel
Copy link
Contributor

@seigel seigel commented Mar 9, 2018

This is a quick and dirty example of where I put the redisdown REDIS_URL in so that one could use redis on
heroku or if your redis server is not on localhost. This example is based on a 2016 hack that I did, and I
haven't proved it out on the most recent plugin based code.

@marten-de-vries
Copy link
Member

Thanks for your pull request. Sorry for getting to this only now. I'm happy to merge this change provided it passes the test suite. If you could rebase it against the latest master, that should fix the current Travis errors.

@seigel
Copy link
Contributor Author

seigel commented Jun 5, 2018

I will take a look. That was a while ago ;)

This is a quick and dirty example of where I put the redisdown REDIS_URL in so that one could use redis on
heroku or if your redis server is not on localhost.  This example is based on a 2016 hack that I did, and I
haven't proved it out on the most recent plugin based code.

Update index.js

Not all level backend databases are redis.
@seigel
Copy link
Contributor Author

seigel commented Jun 6, 2018

Rebased and provided a different URL for leveldown services.

@marten-de-vries marten-de-vries merged commit 0760d97 into pouchdb:master Jun 6, 2018
@marten-de-vries
Copy link
Member

Thanks @seigel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants