Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id regression #1472

Closed
daleharvey opened this issue Feb 23, 2014 · 8 comments
Closed

id regression #1472

daleharvey opened this issue Feb 23, 2014 · 8 comments

Comments

@daleharvey
Copy link
Member

Actually I was wrong, I should have thought about this more, the id changing to name was a regression (also a non backwards compatible change)

@daleharvey
Copy link
Member Author

the problem being if I replicate from a database with the same local name, to the same remote database, I am gonna pick up a checkpoint that doesnt apply to me, needs a partial backout of daleharvey@b53ceda

@daleharvey
Copy link
Member Author

Also I believe couchdb now how a uuid inside its .info as the basis for its replication id generation, so we should do the same

@calvinmetcalf
Copy link
Member

Then we need to make sure that the http and leveldb do that too (previously
only Websql and I'd did)
On Feb 22, 2014 7:37 PM, "Dale Harvey" notifications@github.com wrote:

Also I believe couchdb now how a uuid inside its .info as the basis for
its replication id generation, so we should do the same

Reply to this email directly or view it on GitHubhttps://github.com/daleharvey/pouchdb/issues/1472#issuecomment-35820044
.

@daleharvey
Copy link
Member Author

http didnt need to really, http was uniquely identified by its host / port, although there were problems with that and couch eventually just moved to uuid, similiarly with level it seemed less of an issue since it was a filepath, but really those all have problems and just doing uuid fixes all the problems, il fix that up now

@calvinmetcalf
Copy link
Member

yeah so my bad on that one

On Sat, Feb 22, 2014 at 7:44 PM, Dale Harvey notifications@github.comwrote:

http didnt need to really, http was uniquely identified by its host /
port, although there were problems with that and couch eventually just
moved to uuid, similiarly with level it seemed less of an issue since it
was a filepath, but really those all have problems and just doing uuid
fixes all the problems, il fix that up now

Reply to this email directly or view it on GitHubhttps://github.com/daleharvey/pouchdb/issues/1472#issuecomment-35820186
.

-Calvin W. Metcalf

@daleharvey
Copy link
Member Author

thats why we do code reve.....shit

@calvinmetcalf
Copy link
Member

we should also switch the test back to just testing it's a string

@daleharvey
Copy link
Member Author

daleharvey@24b2143

sygi pushed a commit to sygi/pouchdb that referenced this issue Apr 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants