Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replicate context #2735

Closed
calvinmetcalf opened this issue Sep 5, 2014 · 4 comments
Closed

replicate context #2735

calvinmetcalf opened this issue Sep 5, 2014 · 4 comments

Comments

@calvinmetcalf
Copy link
Member

PouchDB.replicate now cares about context if you give it strings, e.g. you can't do var replicate = PouchDB.replicate, replicate("string1", "string2"); ugh

@calvinmetcalf
Copy link
Member Author

this is #2734 the issue is actually that

pouchdb/lib/sync.js

Lines 34 to 35 in d3d1f2a

var srcPouch = replication.toPouch(src, opts);
var targPouch = replication.toPouch(target, opts);
doesn't pass in context, we're going to need to publish 3.0.5 soon I think (and why weren't we testing this)

@calvinmetcalf
Copy link
Member Author

and it's because we never test withouth calling PouchDB.defaults

@calvinmetcalf
Copy link
Member Author

nope it's because we never do sync with just names

@nolanlawson
Copy link
Member

4a90552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants