Eventemitter leak in changes() listener in replication (yes, again) #4093

nolanlawson · 2015-07-31T19:46:03Z

Apparently we are still able to get memory leaks during replication if the server throws a 503 (local-npm/local-npm#39). I have no idea how that's possible, though, since I thought we fixed and tested that in d8902a1. Maybe it doesn't work if you neglect to cancel() after an error?

The text was updated successfully, but these errors were encountered:

daleharvey · 2015-09-04T22:11:50Z

So this should hopefully be fixed in 691df0d

Problem ------- With the idb adapter (default in Chrome), calling `.changes()` or `.replicate()` with `{live: true}` multiple times results this error, even when the handler is nicely terminated with `.cancel()`. (node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit. Related to pouchdb#4176, pouchdb#4141, pouchdb#4093, pouchdb#3848, pouchdb#2667, pouchdb#2311, pouchdb#2205, and maybe others. How to reproduce the bug? ------------------------- Run this plunkr: Alternatively, you can create + cancel a `.changes()` feed a few times: changesHandler = db.changes({live: true}); changesHandler.cancel(); repeat About this fix -------------- The bug comes from the `_change()` API call from the idb adapter [1] returning `undefined` instead of the `{cancel: function() {...}}` object it should return [2]. Because of that, the cleanup function in the core module doesn't call the adapter's `cancel()` function [3], letting a listener into the wild. This commit fixes that. [1]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-adapter-idb/src/index.js#L420-L422 [2]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-adapter-idb/src/changes.js#L29-L33 [3]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-core/src/changes.js#L201-L209

Problem ------- With the idb adapter (default in Chrome), calling `.changes()` or `.replicate()` with `{live: true}` multiple times results this error, even when the handler is nicely terminated with `.cancel()`. (node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit. Related to pouchdb#4176, pouchdb#4141, pouchdb#4093, pouchdb#3848, pouchdb#2667, pouchdb#2311, pouchdb#2205, and maybe others. How to reproduce the bug? ------------------------- Run this plunkr: http://plnkr.co/edit/JKCbQ6vwlYClAp6ZSAf4?p=preview Alternatively, you can create + cancel a `.changes()` feed a few times: changesHandler = db.changes({live: true}); changesHandler.cancel(); repeat About this fix -------------- The bug comes from the `_change()` API call from the idb adapter [1] returning `undefined` instead of the `{cancel: function() {...}}` object it should return [2]. Because of that, the cleanup function in the core module doesn't call the adapter's `cancel()` function [3], letting a listener into the wild. This commit fixes that. [1]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-adapter-idb/src/index.js#L420-L422 [2]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-adapter-idb/src/changes.js#L29-L33 [3]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-core/src/changes.js#L201-L209

Problem ------- With the idb adapter (default in Chrome), calling `.changes()` or `.replicate()` with `{live: true}` multiple times results in this error, even when the handler is nicely terminated with `.cancel()`. (node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit. Related to pouchdb#4176, pouchdb#4141, pouchdb#4093, pouchdb#3848, pouchdb#2667, pouchdb#2311, pouchdb#2205, and maybe others. How to reproduce the bug? ------------------------- Run this plunkr: http://plnkr.co/edit/JKCbQ6vwlYClAp6ZSAf4?p=preview Alternatively, you can create + cancel a `.changes()` feed a few times: changesHandler = db.changes({live: true}); changesHandler.cancel(); repeat About this fix -------------- The bug comes from the `_change()` API call from the idb adapter [1] returning `undefined` instead of the `{cancel: function() {...}}` object it should return [2]. Because of that, the cleanup function in the core module doesn't call the adapter's `cancel()` function [3], letting a listener into the wild. This commit fixes that. [1]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-adapter-idb/src/index.js#L420-L422 [2]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-adapter-idb/src/changes.js#L29-L33 [3]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-core/src/changes.js#L201-L209

Problem ------- With the idb adapter (default in Chrome), calling `.changes()` or `.replicate()` with `{live: true}` multiple times results in this error, even when the handler is nicely terminated with `.cancel()`. (node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit. Related to pouchdb#4176, pouchdb#4141, pouchdb#4093, pouchdb#3848, pouchdb#2667, pouchdb#2311, pouchdb#2205, and maybe others. How to reproduce the bug? ------------------------- Run this plunkr: http://plnkr.co/edit/JKCbQ6vwlYClAp6ZSAf4?p=preview Alternatively, you can create + cancel a `.changes()` feed a few times: changesHandler = db.changes({live: true}); changesHandler.cancel(); repeat About this fix -------------- The bug comes from the `_change()` API call from the idb adapter [1] returning `undefined` instead of the `{cancel: function() {...}}` object it should return [2]. Because of that, the cleanup function in the core module doesn't call the adapter's `cancel()` function [3], letting a listener into the wild. This commit fixes that and adds a test to check for the presence of the error log line. [1]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-adapter-idb/src/index.js#L420-L422 [2]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-adapter-idb/src/changes.js#L29-L33 [3]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-core/src/changes.js#L201-L209

Problem ------- With the idb adapter (default in Chrome), calling `.changes()` or `.replicate()` with `{live: true}` multiple times results in this error, even when the handler is nicely terminated with `.cancel()`. (node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit. Related to #4176, #4141, #4093, #3848, #2667, #2311, #2205, and maybe others. How to reproduce the bug? ------------------------- Run this plunkr: http://plnkr.co/edit/JKCbQ6vwlYClAp6ZSAf4?p=preview Alternatively, you can create + cancel a `.changes()` feed a few times: changesHandler = db.changes({live: true}); changesHandler.cancel(); repeat About this fix -------------- The bug comes from the `_change()` API call from the idb adapter [1] returning `undefined` instead of the `{cancel: function() {...}}` object it should return [2]. Because of that, the cleanup function in the core module doesn't call the adapter's `cancel()` function [3], letting a listener into the wild. This commit fixes that and adds a test to check for the presence of the error log line. [1]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-adapter-idb/src/index.js#L420-L422 [2]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-adapter-idb/src/changes.js#L29-L33 [3]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-core/src/changes.js#L201-L209

Problem ------- With the idb adapter (default in Chrome), calling `.changes()` or `.replicate()` with `{live: true}` multiple times results in this error, even when the handler is nicely terminated with `.cancel()`. (node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit. Related to pouchdb#4176, pouchdb#4141, pouchdb#4093, pouchdb#3848, pouchdb#2667, pouchdb#2311, pouchdb#2205, and maybe others. How to reproduce the bug? ------------------------- Run this plunkr: http://plnkr.co/edit/JKCbQ6vwlYClAp6ZSAf4?p=preview Alternatively, you can create + cancel a `.changes()` feed a few times: changesHandler = db.changes({live: true}); changesHandler.cancel(); repeat About this fix -------------- The bug comes from the `_change()` API call from the idb adapter [1] returning `undefined` instead of the `{cancel: function() {...}}` object it should return [2]. Because of that, the cleanup function in the core module doesn't call the adapter's `cancel()` function [3], letting a listener into the wild. This commit fixes that and adds a test to check for the presence of the error log line. [1]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-adapter-idb/src/index.js#L420-L422 [2]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-adapter-idb/src/changes.js#L29-L33 [3]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-core/src/changes.js#L201-L209

Problem ------- With the idb adapter (default in Chrome), calling `.changes()` or `.replicate()` with `{live: true}` multiple times results in this error, even when the handler is nicely terminated with `.cancel()`. (node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit. Related to #4176, #4141, #4093, #3848, #2667, #2311, #2205, and maybe others. How to reproduce the bug? ------------------------- Run this plunkr: http://plnkr.co/edit/JKCbQ6vwlYClAp6ZSAf4?p=preview Alternatively, you can create + cancel a `.changes()` feed a few times: changesHandler = db.changes({live: true}); changesHandler.cancel(); repeat About this fix -------------- The bug comes from the `_change()` API call from the idb adapter [1] returning `undefined` instead of the `{cancel: function() {...}}` object it should return [2]. Because of that, the cleanup function in the core module doesn't call the adapter's `cancel()` function [3], letting a listener into the wild. This commit fixes that and adds a test to check for the presence of the error log line. [1]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-adapter-idb/src/index.js#L420-L422 [2]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-adapter-idb/src/changes.js#L29-L33 [3]: https://github.com/pouchdb/pouchdb/blob/49e4945/packages/node_modules/pouchdb-core/src/changes.js#L201-L209

This was referenced Jul 31, 2015

Replication completely resets on timeout local-npm/local-npm#39

Closed

(#39 #40) - fix replication over bad connection local-npm/local-npm#41

Merged

daleharvey added the bug Confirmed bug label Aug 4, 2015

daleharvey mentioned this issue Aug 4, 2015

Replication event handlers must not throw exceptions #3715

Closed

daleharvey closed this as completed Sep 4, 2015

adrienverge mentioned this issue May 16, 2017

pouchdb-adapter-idb: fix "possible EventEmitter memory leak detected" #6504

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Eventemitter leak in changes() listener in replication (yes, again) #4093

Eventemitter leak in changes() listener in replication (yes, again) #4093

nolanlawson commented Jul 31, 2015

daleharvey commented Sep 4, 2015

Eventemitter leak in changes() listener in replication (yes, again) #4093

Eventemitter leak in changes() listener in replication (yes, again) #4093

Comments

nolanlawson commented Jul 31, 2015

daleharvey commented Sep 4, 2015