Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all tests need a rebuild before testing #4762

Closed
daleharvey opened this issue Jan 8, 2016 · 5 comments
Closed

all tests need a rebuild before testing #4762

daleharvey opened this issue Jan 8, 2016 · 5 comments
Labels
enhancement Feature request

Comments

@daleharvey
Copy link
Member

I think with the extra compile step there are going to be a few of these. We can just put npm run build before test component however its a long build process

@nolanlawson in the work you are doing in #4741, would it be possible to split out the build steps so if we only need the babel conversion we can do only that, then only build pouchdb.js and a seperate one to do all the fruitdown and the plugins etc

@daleharvey daleharvey added the enhancement Feature request label Jan 9, 2016
@daleharvey daleharvey changed the title Component tests need a rebuild before testing all tests need a rebuild before testing Jan 9, 2016
@daleharvey
Copy link
Member Author

Just making note that npm test needs this too

@nolanlawson
Copy link
Member

Not sure what you mean by this? In Travis, we always do an npm run build after npm install (it's a prepublish, so it happens automatically), and for npm run dev, the whole codebase is rebuilt anytime a single file changes.

My idea for a workflow here was that, if you were just testing Node-related stuff (i.e. you didn't have npm run dev running), you'd just run npm run build before you do npm t or whatever your test step is. Doing it automatically would be nice for development, but it'd be hard to stop Travis from needlessly running the build twice.

@daleharvey
Copy link
Member Author

It wasnt for travis was meaning local workflows, its confusing to have to know which tests you need to do a npm run build before or not, I think npm install && npm test should basically always work. I have the PR for fixing it up now though

@nolanlawson
Copy link
Member

npm install will automatically do npm run build, yeah. The only really tricky one is the unit tests, since those need npm run build-as-modular-es5, which was a dirty hack, but I couldn't figure out a better way.

@daleharvey
Copy link
Member Author

Fixed in 443cd66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request
Projects
None yet
Development

No branches or pull requests

2 participants