node-websql uses _pouchdb_ prefix for databases

[nolanlawson]

This should never have slipped through; not sure how I didn't notice.

It can be fixed as easily as adding .use_prefix = false to the websql adapter, when running in Node. It should be a one-line code change.

Normally I'd consider this a breaking change, but if we can get this patch out quickly I'd consider it a patch. The feature only shipped in 5.3.0.

[daleharvey]

Why is using the prefix considered a bug? seems like it should be

[nolanlawson]

In Node we don't use a prefix, so that it's easier to rimraf as necessary. In the browser we do use it, to avoid conflicting with other IDB/WebSQL libs.

TBH if I could go back in time I'd say we should never have supported prefixes for any adapter (users should just be expected not to let their IDB/WebSQL libs conflict), but now we're in this situation.

[daleharvey]

Sounds good to me, I still think its a good idea to prevent conflicting names in the browser, I am regularly using localForage etc in combination with PouchDB, I think others are too and it was something that came up early and was hugely confusing, that fix looks good though, fixed in 121a527

[nolanlawson]

Fair enough; it's not something I'm going to push hard for. It just bugs me in the code that _prefixkeeps popping up everywhere, but it's not a big deal.