Use fixed-length array in idb/indexeddb allDocs #7040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So there has been efforts to try and get our performance tests ready for production, fail CI if we get performance regressions and a dashboard of what our performance looks like. If you are interested in doing that would be happy to discuss in a new issue. As for this improvment its a simple change that doesnt complicate the code so happy to merge, thank you :) |
|
Thanks for merging! Ref perf testing, I'm very interested in learning more. I'll take a look at the current suite and see if my change had any effect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been benchmarking
db.allDocs({ keys: someIds }), and this PR may have a significant effect for some users.Initialising arrays with a known length seems to be much faster in Chrome than using
[]. In Firefox, there seems to be little difference.https://jsperf.com/random-array-inserts
Running the same benchmark directly in the Chrome console* seems to have even more marked differences, but presumably there's some other factor at play:
N.B.
COUNT = 20000*application which includes PouchDB was also loaded in this browser window.