(#1167) - acutal error objects

[calvinmetcalf]

pull for #1167, tests inexplicably fail in node for me, not sure why.

[calvinmetcalf]

nope not just me

[calvinmetcalf]

now with passing tests!

[daleharvey]

nit: the spacing here is all wrong (are we linting this?), also the use of obj is very confusing

[daleharvey]

There is some nits around inconsistent spacing

if (stuff) { 
    ... 
} else { 

etc, I though we were enforcing that via jshint, but dont have time to check right now sorry, otherwise looks great 👍 to merge with nits fixed

[calvinmetcalf]

hm lemme look

[calvinmetcalf]

ah we forgot to add deps to the jshint path

[calvinmetcalf]

on second thought I'm going to fix the lint errors that apply to this pull and not try to get all of deps to pass jshint as that turned out to be a more massive undertaking

[daleharvey]

Originally 'deps' were external deps and specifically not jshinted (stuff
like jquery), but at this point very little of it isnt ours, should have
thought about before starting to merge code in there, sorry

On 21 December 2013 17:31, Calvin Metcalf notifications@github.com wrote:

on second thought I'm going to fix the lint errors that apply to this pull
and not try to get all of deps to pass jshint as that turned out to be a
more massive undertaking

—
Reply to this email directly or view it on GitHubhttps://github.com/daleharvey/pouchdb/pull/1168#issuecomment-31067800
.

[daleharvey]

And also +1 on merging this prior to doing a silly large jshint commit, (another nit would be spelling error in commit message)

Sorry I am not merging stuff at the moment, on a boat with crappy wifi