(#1175) - Handle HTTP codes other than 200/404 during repl #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replication should invoke callback if it receives HTTP error codes other than 404 and 200. (Which might be returned from the DB server or from an intermediary reverse proxy). It seems that there was an oversight which could lead to HTTP 500s to otherwise trigger neither success nor err-callback behavior.
|
it's fantastic, merged 5b93578 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replication should invoke callback if it receives HTTP error codes
other than 404 and 200. (Which might be returned from the DB server
or from an intermediary reverse proxy). It seems that there was an
oversight which could lead to HTTP 500s to otherwise trigger neither
success nor err-callback behavior.