Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulkdocs response may not contain .ok property #2365

Closed
wants to merge 1 commit into from

Conversation

ssured
Copy link
Contributor

@ssured ssured commented Jun 7, 2014

I hit this case when syncing against Sync Gateway. First I thought it was a SG issue, but according to CouchDB docs SG is conformant.

See https://wiki.apache.org/couchdb/HTTP_Bulk_Document_API under 'Modify Multiple Documents With a Single Request' they have a sample response.

Another approach could be checking for res.error

I hit this case when syncing against Sync Gateway.
@nolanlawson
Copy link
Member

Seems like a pretty obvious fix. The logic could be simplified to just if (!(res.id && res.rev)), though, no? I'm guessing Cloudant sends back just {}?

@calvinmetcalf
Copy link
Member

54e5224

nolanlawson referenced this pull request Jun 13, 2014
I hit this case when syncing against Sync Gateway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants