Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(pouchdb/express-pouchdb#61) - {ok:true} for put #2390

Closed
wants to merge 1 commit into from

Conversation

nolanlawson
Copy link
Member

This ensures that all adapters (even Cloudant)
return ok:true for put/post/bulkDocs/putLocal.
Also it essentially reverts 54e5224 and instead
follows @calvinmetcalf's advice in that thread
to smooth out whatever the server sends us.

This ensures that all adapters (even Cloudant)
return ok:true for put/post/bulkDocs/putLocal.
Also it essentially reverts 54e5224 and instead
follows @calvinmetcalf's advice in that thread
to smooth out whatever the server sends us.
@nolanlawson
Copy link
Member Author

manually confirmed that the pouchdb-server tests pass with this fix (assuming npm link to rvagg/node-levelup, since that still needs an update).

@nolanlawson
Copy link
Member Author

BTW this also gets the basics tests working against Cloudant, whereas they were failing before. Unfortunately that's not the only thing that's broken, but it's at least a step.

@calvinmetcalf
Copy link
Member

55ed0df

@calvinmetcalf calvinmetcalf deleted the express-61 branch June 24, 2014 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants