only create one db instance when syncing #2662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinmetcalf
force-pushed
the
one-instance-sync
branch
from
918bcae
to
bf6a440
Compare
calvinmetcalf
added a commit
that referenced
this pull request
Aug 21, 2014
calvinmetcalf
changed the title
|
Just to check: the only thing duplicated is the initial GET/PUT of the db itself, right? Nice catch. |
|
yes (theoretically a race condition?) |
|
Yeah, I think they could both try to PUT at the same time if the database doesn't exist yet. |
nolanlawson
force-pushed
the
one-instance-sync
branch
from
bf6a440
to
f5cffa2
Compare
calvinmetcalf
added a commit
that referenced
this pull request
Aug 28, 2014
|
👍 when green |
|
Actually, you have a typo: var PouchConstructor = opts.PouchConstructor || Pouch;should be var PouchConstructor = opts.pouchConstructor || Pouch;I'll just fix it for you, rebase, and push again. |
nolanlawson
force-pushed
the
one-instance-sync
branch
from
f5cffa2
to
59da6c8
Compare
calvinmetcalf
added a commit
that referenced
this pull request
Sep 2, 2014
|
068c1da0a475f1fc8e872c509b70841ef9db1f23and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently it creates 2 e.g. double http calls all the way through