(#5305) - fix pouchdb-adapter-node-websql #5305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,7 +7,7 @@ function NodeWebSqlPouch(opts, callback) { | |||
| websql: websql // pass node-websql in as our "openDatabase" function | |||
| }, opts); | |||
|
|
|||
| WebSqlPouch.call(this, _opts, callback); | |||
| WebSqlPouchCore.call(this, _opts, callback); | |||
There was a problem hiding this comment.
When this wasn't calling core, it was just uselessly calling what pouchdb-adapter-websql exports, which is the PouchDB.plugin(...) code.
nolanlawson
force-pushed
the
fix-node-websql
branch
from
3213d43
to
3c8756c
Compare
nolanlawson
added a commit
that referenced
this pull request
Jun 7, 2016
|
Actually I was wrong; the test should be using The test fails before the fix but succeeds after. |
| global.PouchDB = global.PouchDB.defaults({ | ||
| prefix: './tmp/_pouch_' | ||
| }); | ||
| delete global.PouchDB.adapters.leveldb; |
There was a problem hiding this comment.
^ this was not actually working before. Instead, it was just running leveldb like normal.
nolanlawson
force-pushed
the
fix-node-websql
branch
from
3c8756c
to
ae4c298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately
pouchdb-adapter-node-websqlis broken due to a typo, and it wasn't caught in CI because it turns out we teeeeechnically only testpouchdb/extras/websql, which is slightly different frompouchdb-adapter-node-websql. Since I think it's silly to run an extra test for a slightly different usage, I've just fixed it manually and gonna call that good.