Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#6040) - fix coveralls badge issue in README #6040

Merged
merged 1 commit into from
Dec 21, 2016
Merged

Conversation

nolanlawson
Copy link
Member

@nolanlawson nolanlawson commented Dec 20, 2016

Apparently Coveralls has a bug where it's not showing 100% even though when you click through clearly everything is at 100%, and the bug has been open for a few years ( lemurheavy/coveralls-public#414 (comment) ). Since our build straight-up fails if we're at <100 I feel comfortable pulling a Volkswagen here and just cheating.

@daleharvey daleharvey merged commit 05c2739 into master Dec 21, 2016
@sbts
Copy link

sbts commented May 1, 2017

@nolanlawson @daleharvey
Hi, don't know if you are aware, but coveralls has a nice easy to use API that allows you to retrieve the current coverage data.

Rather than faking things to get your build to complete, you may want to try the API instead.

I do have some perl code around to retrieve it if you're interested

NOTE: I have no ties to coveralls nor github, however I have had to work around this issue myself.
I also have github-badge-cache-buster which can be added to your test or build infrastructure to attempt a forced cache PURGE on the camo.githubusercontent.com resource for your badges

@sbts
Copy link

sbts commented May 1, 2017

Actually, even easier, here is a curl example that does the job of retrieving the coverage, and uses jq to only return the desired value

curl -s -o /dev/stdout https://coveralls.io/github/ledgersmb/LedgerSMB.json | jq .covered_percent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants