(#7495) - Fix how fetch resolves absolute URIs

[ptitjes]

If the provided path is an absolute path, then resolve the path on the host directly.

[ptitjes]

@daleharvey, @garrensmith can one of review my PR please ?

Resolution of #7495 is mandatory for any plugin that needs to communicate with CouchDB directly, as does PouchDB Authentication.

It would be great if it could be solved and that we have a patch release along with #7395.

[garrensmith]

Sure. But I’ll only get to it on Monday.

…

________________________________ From: ptitjes <notifications@github.com> Sent: Thursday, November 1, 2018 7:55:06 PM To: pouchdb/pouchdb Cc: garren smith; Mention Subject: Re: [pouchdb/pouchdb] (#7495) - Fix how `fetch` resolves absolute URIs (#7496) @daleharvey<https://github.com/daleharvey>, @garrensmith<https://github.com/garrensmith> can one of review my PR please ? Resolution of #7495<#7495> is mandatory for any plugin that needs to communicate with CouchDB directly, as does PouchDB Authentication. It would be great if it could be solved and that we have a patch release along with #7395<#7395>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#7496 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAK9App9w5ZCcjGtnXlwzRE-qFB_6kcNks5uqzV5gaJpZM4Xk05X>.

[daleharvey]

Hey sorry for the delay, you posted just as I went on holiday, will get to this by tomorrow latest, cheers

[ptitjes]

No problem guys. I was just worried to miss the release, which I feel might come soon :)

[daleharvey]

lol so I looked into this, silly that I missed it before, we use es5 aside from modules so let needs to be var, this straight up breaks the entire build during minification which is a silly bug on our end somewhere but an easy fix

[ptitjes]

Oh sorry. That's too much switching between projects... I'll try to fix that tomorrow!

[ptitjes]

@daleharvey So there is only a failure with message Unable to get property 'rows' of undefined or null reference (http://127.0.0.1:8000/tests/integration/test.design_docs.js:90)" on both IE11:Windows 10 tests. Any hint on how it is related to my changes ?

[daleharvey]

@ptitjes Its very unlikely this bug is related to your changes, ie (and iphone) are quite unstable browsers in when run in selenium, will restart to confirm and likely this is good to go when green

[daleharvey]

Actually I should have looked more carefully, the failures are both ie11 and you are using startsWith, probably easiest to just switch that to a regex or can just use a replacement function (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/startsWith) but not polyfill, we dont want to touch the string prototype

[ptitjes]

@daleharvey I fixed it by using substr. There is now only one test failing with a timeout :D

[ptitjes]

Finally passing on IE :) <3

[daleharvey]

Great job cheers

[ptitjes]

@daleharvey Is the « don't use the big green button » still the policy ? Or we can use the "Squash and merge" or "Rebase and merge" ?

[daleharvey]

Did we write dont use the big green button down anywhere? github fixed it a while ago so we have set so it will squash and merge without making a merge commit

[daleharvey]

ie using the big green button is fine now

[ptitjes]

Yep, still written here: https://github.com/pouchdb/pouchdb/blob/master/CONTRIBUTING.md#committers