Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: input isn't defined in array case #8890

Merged
merged 2 commits into from
Mar 30, 2024
Merged

fix: input isn't defined in array case #8890

merged 2 commits into from
Mar 30, 2024

Conversation

SourceR85
Copy link
Contributor

Fixed comparison against an undeclared/undefined variable (value !== null always evaluates to undefined !== null when input is an array)

To me it looks like a copy & past mistake (102 looks similar to line 124)

garethbowen
garethbowen approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Can you add a test that proves this?

@SourceR85
Copy link
Contributor Author

SourceR85 commented Mar 30, 2024 •
edited
Loading

Can you add a test that proves this?

Included now (just found other null related problems on the way: #8898, #8899, #8900, and #8901)

@SourceR85 SourceR85 merged commit 1866900 into pouchdb:master Mar 30, 2024
98 checks passed
@SourceR85 SourceR85 deleted the fix-undefined-in-validateSelector.js branch March 30, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethbowen garethbowen garethbowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SourceR85 @garethbowen