Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing BiocCheck() #54

Open
19 of 21 tasks
hackdna opened this issue Nov 17, 2021 · 3 comments
Open
19 of 21 tasks

Passing BiocCheck() #54

hackdna opened this issue Nov 17, 2021 · 3 comments
Assignees

Comments

@hackdna
Copy link
Collaborator

hackdna commented Nov 17, 2021

Errors

Warnings

  • "Description field in the DESCRIPTION file is too concise"
  • "Evaluate more vignette chunks."
  • "Remove set.seed usage (found 5 times)"
  • "Avoid T/F variables; If logical, use TRUE/FALSE (found 51 times)"
  • "The following files are over 5MB in size: '.git/objects/33/d794a2db6598e9fd6808ee815a21af38fb1f48 .git/objects/77/40f0f0d0abee5c3fee0c13d1eeeea044c62fa7 .git/objects/pack/pack-c37633e5c2521abc60f069884252e737552ee3dc.pack'"

Notes

  • " 'sessionInfo' not found in vignette(s)"
  • " Avoid the use of 'paste' in condition signals"
  • "Recommended function length <= 50 lines."
  • "Consider adding a NEWS file, so your package news will be included in Bioconductor release announcements."
  • "Consider shorter lines; 6 lines (0%) are > 80 characters long."
  • "Consider multiples of 4 spaces for line indents, 758 lines(32%) are not."
  • "Cannot determine whether maintainer is subscribed to the bioc-devel mailing list (requires admin credentials). Subscribe here: https://stat.ethz.ch/mailman/listinfo/bioc-devel"
  • " Avoid sapply(); use vapply()"
  • " Avoid 1:...; use seq_len() or seq_along()"
  • "'LazyData:' in the 'DESCRIPTION' should be set to false or removed" - [x] "Update R version dependency from 2.10 to 4.1.0."
@hackdna
Copy link
Collaborator Author

hackdna commented Nov 19, 2021

Closed by mistake in PR.

@hackdna hackdna reopened this Nov 19, 2021
@pouryany
Copy link
Owner

Just added the PanomiR tag to my Bioc support profile.

pouryany pushed a commit that referenced this issue Nov 22, 2021
pouryany pushed a commit that referenced this issue Nov 22, 2021
one instance of set seed is unavoidable. I have added a user input if they would like to use system determined seeds.
pouryany pushed a commit that referenced this issue Nov 22, 2021
pouryany pushed a commit that referenced this issue Nov 30, 2021
hackdna pushed a commit that referenced this issue Nov 30, 2021
hackdna added a commit that referenced this issue Nov 30, 2021
Fix Avoid 1:... with seq_len, toward #54

Former-commit-id: 32b8e51
Former-commit-id: 508ae69db47a04e7c7c1e685d51f508504a6ba2a
hackdna pushed a commit that referenced this issue Nov 30, 2021
Former-commit-id: e2aeafa
Former-commit-id: ed8f0eeb47172647cef01ce00fa3a416d4410a7e
hackdna pushed a commit that referenced this issue Nov 30, 2021
Former-commit-id: 35c8a8d
Former-commit-id: cec8b3c8d3e9b7de13dfd9bfcce925b94a85f186
Former-commit-id: 88997ec
hackdna added a commit that referenced this issue Nov 30, 2021
Fix Avoid 1:... with seq_len, toward #54

Former-commit-id: 32b8e51
Former-commit-id: 508ae69db47a04e7c7c1e685d51f508504a6ba2a
Former-commit-id: 3fc8101
hackdna pushed a commit that referenced this issue Nov 30, 2021
Former-commit-id: e2aeafa
Former-commit-id: ed8f0eeb47172647cef01ce00fa3a416d4410a7e
Former-commit-id: ef86fde
hackdna pushed a commit that referenced this issue Nov 30, 2021
Former-commit-id: 35c8a8d
Former-commit-id: cec8b3c8d3e9b7de13dfd9bfcce925b94a85f186
Former-commit-id: 88997ec
Former-commit-id: b3a5d22
hackdna added a commit that referenced this issue Nov 30, 2021
Fix Avoid 1:... with seq_len, toward #54

Former-commit-id: 32b8e51
Former-commit-id: 508ae69db47a04e7c7c1e685d51f508504a6ba2a
Former-commit-id: 3fc8101
Former-commit-id: fa986b2
hackdna pushed a commit that referenced this issue Nov 30, 2021
Former-commit-id: e2aeafa
Former-commit-id: ed8f0eeb47172647cef01ce00fa3a416d4410a7e
Former-commit-id: ef86fde
Former-commit-id: 8759f3d
hackdna pushed a commit that referenced this issue Nov 30, 2021
Former-commit-id: 35c8a8d
Former-commit-id: cec8b3c8d3e9b7de13dfd9bfcce925b94a85f186
Former-commit-id: 88997ec
Former-commit-id: b3a5d22
Former-commit-id: cdc1383
hackdna added a commit that referenced this issue Nov 30, 2021
Fix Avoid 1:... with seq_len, toward #54

Former-commit-id: 32b8e51
Former-commit-id: 508ae69db47a04e7c7c1e685d51f508504a6ba2a
Former-commit-id: 3fc8101
Former-commit-id: fa986b2
Former-commit-id: 1653ceb
hackdna pushed a commit that referenced this issue Nov 30, 2021
Former-commit-id: e2aeafa
Former-commit-id: ed8f0eeb47172647cef01ce00fa3a416d4410a7e
Former-commit-id: ef86fde
Former-commit-id: 8759f3d
Former-commit-id: 6fa555b
@hackdna hackdna reopened this Nov 30, 2021
pouryany pushed a commit that referenced this issue Nov 30, 2021
Fix Avoid 1:... with seq_len, toward #54

Former-commit-id: 6f26432d1dbb4e8577cb980da4623bb123a303cf [formerly 28a397bf5c61b92d396c2ae6dbf3a5e1e8a04142] [formerly 37b45aef16bd2df4fde123486fde03b73d261c50 [formerly 32b8e51]]
Former-commit-id: 508ae69db47a04e7c7c1e685d51f508504a6ba2a
Former-commit-id: 3fc8101
Former-commit-id: fa986b2
Former-commit-id: 1653ceb
Former-commit-id: 69f60ffd7de961c54c00a53f3ab4a5abef88c9ae [formerly 500eb85]
Former-commit-id: 7e2c6b60e87b01cd67f7e0ead1bad7026c612a12
pouryany added a commit that referenced this issue Nov 30, 2021
Former-commit-id: 9706c5e4a6fabddb8bd3d9eb6de5028d4c01a064 [formerly 5bf5691ebf47b3f716f3438a430fea442da5a66d] [formerly 7d4b3414c2c5f64e2e9d5d064bbf1f016516d10f [formerly e2aeafa]]
Former-commit-id: ed8f0eeb47172647cef01ce00fa3a416d4410a7e
Former-commit-id: ef86fde
Former-commit-id: 8759f3d
Former-commit-id: 6fa555b
Former-commit-id: 67ac30477c2d2b985ba0861adc9b9839f6e0f8c0 [formerly 9a7806d]
Former-commit-id: fa433f9ee38057770fd639503edbbaf58b66db23
@hackdna hackdna reopened this Nov 30, 2021
pouryany pushed a commit that referenced this issue Dec 1, 2021
pouryany pushed a commit that referenced this issue Dec 1, 2021
@pouryany
Copy link
Owner

pouryany commented Dec 1, 2021

There is a conflict between the indenting 4 spaces rule and Roxygen generated manuals (where they automatically have 2 indents in the \usage{} field). Upon submission, this should be clarified as discussed in the issue below.

r-lib/roxygen2#332

pouryany pushed a commit that referenced this issue Dec 1, 2021
pouryany pushed a commit that referenced this issue Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants