Avoid creating an intermediate vector (#1457)

powdr-labs · Jun 26, 2024 · 924b9b0 · 924b9b0
1 parent b967552
commit 924b9b0
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/executor/src/witgen/identity_processor.rs b/executor/src/witgen/identity_processor.rs
@@ -168,15 +168,10 @@ impl<'a, 'b, 'c, T: FieldElement, Q: QueryCallback<T>> IdentityProcessor<'a, 'b,
             }
         }
 
-        let left = identity
-            .left
-            .expressions
-            .iter()
-            .map(|e| rows.evaluate(e))
-            .collect::<Vec<_>>();
+        let left = identity.left.expressions.iter().map(|e| rows.evaluate(e));
 
         // Fail if the LHS has an error.
-        let (left, errors): (Vec<_>, Vec<_>) = left.into_iter().partition_map(|x| match x {
+        let (left, errors): (Vec<_>, Vec<_>) = left.partition_map(|x| match x {
             Ok(x) => Either::Left(x),
             Err(x) => Either::Right(x),
         });