Remove is_first from top-level
#1511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
approved these changes
Jul 1, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
Includes #1511, but also removes the declarations of the challenges in the `permutation` and `lookup` modules. With these changes, we never declare a column or challenge outside a machine namespace. This greatly simplifies #1470. --------- Co-authored-by: schaeff <thibaut@schaeff.fr> Co-authored-by: chriseth <chris@ethereum.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure that columns are only defined inside namespaces.
is_firstis passed as argument as it is currently not possible to declare fixed columns within functions.