Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for multiple paths #639

Open
wants to merge 3 commits into
base: v2
Choose a base branch
from
Open

Look for multiple paths #639

wants to merge 3 commits into from

Conversation

ZeoNight
Copy link

@ZeoNight ZeoNight commented May 3, 2022

No description provided.

@ZeoNight
Copy link
Author

ZeoNight commented May 3, 2022

Heyo! This happend to me when I was on linux where I had 2 instances and it was installing to the wrong instance. This is a quick fix for it.

@LandenStephenss
Copy link
Contributor

Now make it do the same on MacOS and Windows

@ZeoNight
Copy link
Author

ZeoNight commented May 3, 2022

Now make it do the same on MacOS and Windows

MacOS and windows don't have multiple paths!

@LandenStephenss
Copy link
Contributor

?? they can, just move the canary install and some other things and boom another path

@ZeoNight
Copy link
Author

ZeoNight commented May 3, 2022

?? they can, just move the canary install and some other things and boom another path

The current power cord build doesn't support multiple paths for either windows or MacOS. They are just 1 path. The linux path tries to see if one of many install locations exist.

injectors/linux.js Outdated Show resolved Hide resolved
@ZeoNight
Copy link
Author

ZeoNight commented May 4, 2022

@Vendicated Anything else?

@ZeoNight
Copy link
Author

fixed conflicts

@ZeoNight
Copy link
Author

ZeoNight commented Jul 5, 2022

Can someone review this? Its been a while

Copy link
Contributor

@asportnoy asportnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants