Azure Cloud Driver #124
Merged
Azure Cloud Driver #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
paramiko has fixed and released the issue. 2.5.0. will update setup.py to require at least that version of paramiko (which is used via spur). |
mikeln
force-pushed
the
azure1
branch
3 times, most recently
from
c50f319
to
9b79073
Compare
Signed-off-by: Mikel Nelson <github@mikelnelson.net> add a new option to pass kill command template Signed-off-by: Mikolaj Pawlikowski <mikolaj@pawlikowski.pl> pass the kill command template and store in the remote executor Signed-off-by: Mikolaj Pawlikowski <mikolaj@pawlikowski.pl> just a docstring on remote executor Signed-off-by: Mikolaj Pawlikowski <mikolaj@pawlikowski.pl> add a method to generate a kill command Signed-off-by: Mikolaj Pawlikowski <mikolaj@pawlikowski.pl> use the new method in the command line prompt Signed-off-by: Mikolaj Pawlikowski <mikolaj@pawlikowski.pl> use the same method to generate kill command in pod scenarios Signed-off-by: Mikolaj Pawlikowski <mikolaj@pawlikowski.pl> aaaand all these other places that should no longer use the template directly Signed-off-by: Mikolaj Pawlikowski <mikolaj@pawlikowski.pl> use the real RemoteExecutor in the tests to expose the new get_kill_command method Signed-off-by: Mikolaj Pawlikowski <mikolaj@pawlikowski.pl> minor version bump Signed-off-by: Mikolaj Pawlikowski <mikolaj@pawlikowski.pl> Fix steps example Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com> Fix input compatibility Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com> Fix YAML load() Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com> add dependency for paramiko Signed-off-by: Mikel Nelson <github@mikelnelson.net>
Signed-off-by: Mikolaj Pawlikowski <mikolaj@pawlikowski.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Azure Cloud Driver.
Note: paramiko library changes are required for communication with Azure nodes.
There is an in-flight PR: paramiko/paramiko#1233. A user will have to create their own paramiko lib with those changes to be able to use this driver.
Explicit utf-8 encoding was needed to process the strings returned from Azure Docker commands. This should be ok with all other cloud providers.
New section in overall README for cloud provider specifics added. This should be filled out more in another PR.
Related issue: #101