Skip to content

Support for group14, group16 Kex and HMAC EtM - #1233

Merged
bitprophet merged 10 commits into
paramiko:masterfrom
edgsousa:master
Jun 10, 2019
Merged

Support for group14, group16 Kex and HMAC EtM#1233
bitprophet merged 10 commits into
paramiko:masterfrom
edgsousa:master

Conversation

@edgsousa

Copy link
Copy Markdown
Contributor

Hi

Some devices I work with were upgraded to a ssh config that only allows kex group14-sha256. Also I saw the request #1229, and decided to implement that as well.

@fuhry

fuhry commented Aug 3, 2018

Copy link
Copy Markdown

For anyone who would like an unofficial build with both curve25519+sha256@libssh.org kex support and @edgsousa's EtM patch, I've put those together into a branch here: https://github.com/fuhry/paramiko/tree/curve25519%2Betm

@mikeln

mikeln commented May 7, 2019

Copy link
Copy Markdown

LGTM and it appears to fix several of my issues with SSH to Azure nodes.

@mikeln

mikeln commented May 17, 2019

Copy link
Copy Markdown

How do we get this PR reviewed , merged, and added to a release? I.e. who is the person we need to bother?

@ploxiln

ploxiln commented May 17, 2019

Copy link
Copy Markdown
Contributor

for what it's worth, I've started a fork, merged this and a few other things according to my own taste, and made an initial release: https://github.com/ploxiln/paramiko-ng/releases/tag/2.5.0

@bitprophet

Copy link
Copy Markdown
Member

Merged to latest master, cleaned up some code a bit, fixed a copyright header (I hate you, LGPL) and added a changelog. Then tested against OpenSSH and both new MACs and both new kexen seem to work great. Thanks!

@bitprophet
bitprophet merged commit 4f77e76 into paramiko:master Jun 10, 2019
bitprophet added a commit that referenced this pull request Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants