Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for group14, group16 Kex and HMAC EtM #1233

Merged
merged 10 commits into from Jun 10, 2019
Merged

Conversation

@edgsousa
Copy link
Contributor

@edgsousa edgsousa commented Jun 12, 2018

Hi

Some devices I work with were upgraded to a ssh config that only allows kex group14-sha256. Also I saw the request #1229, and decided to implement that as well.

@fuhry
Copy link

@fuhry fuhry commented Aug 3, 2018

For anyone who would like an unofficial build with both curve25519+sha256@libssh.org kex support and @edgsousa's EtM patch, I've put those together into a branch here: https://github.com/fuhry/paramiko/tree/curve25519%2Betm

@mikeln
Copy link

@mikeln mikeln commented May 7, 2019

LGTM and it appears to fix several of my issues with SSH to Azure nodes.

@mikeln
Copy link

@mikeln mikeln commented May 17, 2019

How do we get this PR reviewed , merged, and added to a release? I.e. who is the person we need to bother?

@ploxiln
Copy link
Contributor

@ploxiln ploxiln commented May 17, 2019

for what it's worth, I've started a fork, merged this and a few other things according to my own taste, and made an initial release: https://github.com/ploxiln/paramiko-ng/releases/tag/2.5.0

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jun 10, 2019

Merged to latest master, cleaned up some code a bit, fixed a copyright header (I hate you, LGPL) and added a changelog. Then tested against OpenSSH and both new MACs and both new kexen seem to work great. Thanks!

@bitprophet bitprophet merged commit 4f77e76 into paramiko:master Jun 10, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants